Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of the internal port of the docker container #300

Closed
puppetm4st3r opened this issue Mar 10, 2024 · 3 comments
Closed

Configuration of the internal port of the docker container #300

puppetm4st3r opened this issue Mar 10, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@puppetm4st3r
Copy link

puppetm4st3r commented Mar 10, 2024

Hi, nice and great Job, im wondering if you can add something like this:

echo 'Starting Aphrodite Engine API server...'

CMD="python3 -m aphrodite.endpoints.${ENDPOINT:-openai}.api_server
             --host 0.0.0.0
             ${SELECTED_PORT:+--port $SELECTED_PORT}
             --download-dir ${HF_HOME}

in certains scenarios with multiple instances of the engine it will be usefull to control the internal listening port of the container.

Regards!

@puppetm4st3r puppetm4st3r changed the title Configuration of the internal port of the docker engine Configuration of the internal port of the docker container Mar 10, 2024
@AlpinDale AlpinDale added the good first issue Good for newcomers label Mar 10, 2024
@puppetm4st3r
Copy link
Author

also will be very useful to install the hf_transfer package inside de image in order to download at the speed of the light, in my case I can get 3x speed in optics fiber when use the hf_transfer by the -e HF_HUB_ENABLE_HF_TRANSFER="true" env var in a modified container with that package.

regards!

@AlpinDale
Copy link
Member

This was fixed yesterday, PORT should be a configurable env variable now.

@puppetm4st3r
Copy link
Author

thaaaanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants