Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ETag #5

Closed
akubera opened this issue May 6, 2016 · 3 comments
Closed

Implement ETag #5

akubera opened this issue May 6, 2016 · 3 comments

Comments

@akubera
Copy link
Member

akubera commented May 6, 2016

ETags are a core feature of web servers that users should expect to work out of the box. This should be a non-middleware feature baked into either Application or HTTPRequest classes, with the option to disable or swap implementations if the user so chooses.

@nudzo
Copy link

nudzo commented May 6, 2016

Get inspired: caddyserver/caddy#191

@akubera
Copy link
Member Author

akubera commented May 10, 2016

Thanks for your suggestion, @nudzo. Do you think it's best to just integrate etags into the static middleware vs some other, more general, mechanism?

@nudzo
Copy link

nudzo commented May 10, 2016

Yes, one I mentioned above is for static content.
Dynamic content best when generate ETags itself, cause it can do it the most effective way - based on version of doc, or hash generated on doc save, or similar. Otherwise you have to calculate some kind of hash on every response - performance impact.

@akubera akubera closed this as completed Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants