Modbus TCP implementation

[ihategoto]

Hello,
I'm currently writing a Modbus TCP client using Minimalmodbus utilities.
The task turned out to be fairly easy as Minimalmodbus provides all the utilities to create the Modbus PDU;
all I had to do was writing utilities to create the MBAP header and the socket management.
My goal is to integrate the Modbus TCP implementation with the current one.
I've been testing the code that I wrote and it seems to behave properly.
I'm writing here because I noticed that the Modbus TCP implementation is not planned for future releases, and my intention was, as soon as the code is ready, to submit a pull request to merge my fork and the original one. Might that be a good idea?

PS: feel free to contribute to my code.

[pyhys]

Hi, thanks for your interest in MInimalModbus.
It is planned than in the future modify the internal representation of the data, now that Python2 support is dropped. So instead of storing data as strings, the data will be stored as bytes. That is a major rewrite of the internals.
Any TCP functionality needs to be done after that.