Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for pyttsx3. #101

Merged
merged 3 commits into from
Mar 21, 2021
Merged

Add hook for pyttsx3. #101

merged 3 commits into from
Mar 21, 2021

Conversation

bwoodsend
Copy link
Member

Add hook for pyttxs3. Fixes pyinstaller/pyinstaller#3268 and a rather long nabble thread.

We do have a hook and test already for pyttxs (without the 3) which is handled similarly but I'd prefer to keep them separate.

There's also a couple of extra commits tucked under here which I can't be bothered to separate into their own PRs. I'll merge this manually to keep the git history.

  • 112f500 CI/CD: Oneshot: Allow custom bash install commands. This is so I can run any sudo apt install [dependencies] when needed.
  • a7fedf0 CI/CD: Oneshot: Remove Python 3.5, add 3.9.

I've done oneshot testing in bits:

They all pass.

@bwoodsend bwoodsend requested review from rokm and a team March 20, 2021 21:09
101.new.rst Outdated Show resolved Hide resolved
bwoodsend added a commit to bwoodsend/pyinstaller-hooks-contrib that referenced this pull request Mar 21, 2021
bwoodsend added a commit to bwoodsend/pyinstaller-hooks-contrib that referenced this pull request Mar 21, 2021
@bwoodsend bwoodsend merged commit b3be175 into pyinstaller:master Mar 21, 2021
@bwoodsend bwoodsend deleted the pyttsx3 branch March 21, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixed / workaround for pyttsx3 test won't work once compiled with pyinstaller
2 participants