Add hook for humanize to collect package metadata #122
Conversation
nicoddemus
requested review from
a team and
bwoodsend
and removed request for
a team
There was a problem hiding this comment.
Was in the midst of saying you've got a linter to appease but you beat me to it!
As a side note - as of pyinstaller/pyinstaller#5830 (i.e. the next release of PyInstaller) metadata collection should be automatic so there shouldn't be so many of these include the metadata hooks in future...
Great news, thanks for the info. 馃憤 Do you know if that will also work for setuptools entry points? This would make pytest plugins (for example) work out of the box, which would be neat. |
No, I did consider doing entry points too but pussied out because I was worried that it would become a clutter magnet. Libraries such as NumPy for example reference There is a relatively new hook utility collect_entry_point() which I added to allow users to opt in to collecting plugins. Funnily enough, streamlining pytest plugin collection was exactly what I wrote it for. |
Great info, thanks. I will have to try that to replace the workarounds we had to do at work in order to freeze pytest + plugins. Awesome work! 馃憤 |
|
I see pyinstaller/pyinstaller#5830 is to blame for that test failure. I better go mop that up before someone accidentally releases it... |
This hook is no longer necessary as of 077552e, since version "2021.2" of the "pyinstaller-hooks-contrib" package now includes also it. See pyinstaller/pyinstaller-hooks-contrib#122
Taken from jmoiron/humanize#105 (comment), credits go to @2press. 馃憤