Add hook for "shotgun_api3" #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiangeisler
requested review from
a team and
bwoodsend
and removed request for
a team
|
I've been knocking together a PR checklist over on #130. Mind guineapig-ing it? You can see it rendered here. That said, you've managed to guess most of it correctly. You just need a news entry. |
|
I added the missing news entry and gave your guide a read through. There is nothing left to add from what I can see. Thanks for checking this PR and writing the guide! 馃檪 |
bwoodsend
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Ok, CI is happy (minus losing connection to the internet half way through anyway).
|
Cheers @fabiangeisler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hook for the Shotgrid python API.
Let me know if there is something missing/wrong with this PR! 馃檪