hooks: scikit-image & scikit-learn: use distribution names for version checks #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is something that I stumbled into while trying to reproduce pyinstaller/pyinstaller#6035 and accidentally installed |
Call is_module_satisfies with distribution name (scikit_learn) instead of package name (sklearn), because running `pip install sklearn` actually installs `sklearn==0.0` and pulls in latest version of `scikit-learn`. So if scikit-learn is accidentally installed this way, the tests will be skipped because the version checks based on package name will fail. Make the same change for scikit-image (scikit_image vs skimage) for the sake of consistency (although in this case, installing `skimage` results in an error telling user to install `scikit-image` instead).
…n checks Use distribution names (scikit_image and scikit_learn) for version checks via is_module_satisfies() instead of package names (skimage and sklearn). It is possible to install latest scikit-learn by installing 'sklearn', which installs `sklearn==0.0` that ends up messing up the version checks. Make same adjustment in scikit-image hooks for the sake of consistency (although trying to install skimage shows an error telling user to install scikit-image instead).
rokm
force-pushed
the
use-sklearn-dist-name
branch
from
682813f
to
2a411cb
Compare
bwoodsend
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use distribution names (
scikit_imageandscikit_learn) for version checks viais_module_satisfies()instead of package names (skimageandsklearn). It is possible to install latestscikit-learnby installing 'sklearn', which installssklearn==0.0that ends up messing up the version checks.Make same adjustment in
scikit-imagehooks for the sake of consistency (although trying to installskimageshows an error telling user to installscikit-imageinstead).