Add hooks for tzdata and zoneinfo/backports.zoneinfo #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
requested review from
a team and
Legorooj
and removed request for
a team
rokm
force-pushed
the
hooks-tzdata-and-zoneinfo
branch
from
de1cf9d
to
1fb5d11
Compare
|
Oneshot runs for backports.zoneinfo on python < 3.9 and for zoneinfo on python 3.9. |
bwoodsend
approved these changes
Oct 26, 2021
Collects timezone data files as well as submodules that are required for proper timezone data discovery via importlib.resources. Add a test that simulates the data loading as performed by zoneinfo and backports.zoneinfo.
On Windows, these packages use timezone data from the tzdata package. Due to lack of direct import (the data is loaded using importlib.resources), we need to add a hiddenimport. On other OSes, system-wide timezone data is used by default.
rokm
force-pushed
the
hooks-tzdata-and-zoneinfo
branch
from
1fb5d11
to
3c41727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.