-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hook to work with astropy version 5.0, which requires metadata #381
Conversation
Awesome! Please let me know when pyinstaller is released with this patch so I know to check the CI downstream. 🙇♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need a news entry.
This situation of having a hook here with no test and your test over on your own repository is a bit awkward. Is there a reason you guys chose not to keep the hook in the astropy repo? |
I dunno... I have to ask @astrofrog |
Done. |
If keeping the hook in the astropy repo itself is the preferred option, that seems reasonable, though I'd also be fine with testing things here. What is the best option? I haven't had a chance to familiarize myself with how a hook would be added directly to the package, but in any case we will need a fix here until a new version of astropy is released, right? If anyone has time to help add the hook to the astropy repo if that is the preferred way forward, that would be great, as I probably won't have time in the near future 🙏 |
It's released. |
Fixes #379 and astropy/astropy#12837