Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for flask_restx #48

Merged
merged 3 commits into from
Sep 13, 2020
Merged

Conversation

mrf345
Copy link
Contributor

@mrf345 mrf345 commented Sep 13, 2020

Problem:
After packaging a flask app that utilizes flask_restx extension, I'm getting an error that indicates the package template files are missing.

Solution:

  • Add a file hook to include the extension template files.
  • Add a reference to the news changelog.

Related Issues:
Fixes #47

@mrf345 mrf345 requested review from a team and bwoodsend and removed request for a team September 13, 2020 17:11
news/48.new.rst Outdated Show resolved Hide resolved
mrf345 and others added 2 commits September 13, 2020 21:49
Co-authored-by: Brénainn Woodsend <30940778+bwoodsend@users.noreply.github.com>
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for providing your own fix to an issue.

@Legorooj Ready to merge?

@Legorooj Legorooj merged commit f853d43 into pyinstaller:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hook for flask_restx missing template files.
3 participants