Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettytable hook #77

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Add prettytable hook #77

merged 2 commits into from
Nov 27, 2020

Conversation

krellsebastian
Copy link
Contributor

Add hook-prettytable.py: pyinstaller not working with prettytable module.
Fixes pyinstaller/pyinstaller#5319

Add hook-prettytable.py: pyinstaller not working with prettytable module. 
As mentioned in pyinstaller/pyinstaller#5319 this changes enables pyinstaller to handle prettytable correctly.
Added prettytable hook news file
@krellsebastian krellsebastian requested review from a team and bwoodsend and removed request for a team November 27, 2020 19:33
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nailed it in one! Perfect thanks.

@bwoodsend bwoodsend merged commit efca6c9 into pyinstaller:master Nov 27, 2020
@@ -0,0 +1 @@
Add a hook for prettytable which requires its distribution metadata.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add a hook for prettytable which requires its distribution metadata.
Add a hook for ``prettytable`` which requires its distribution metadata.

@rokm
Copy link
Member

rokm commented Nov 27, 2020

The number in news fragment filename should match the number of this PR (i.e., 77.new.rst instead of 72.new.rst). Other than that, look good. Thanks!

bwoodsend pushed a commit that referenced this pull request Nov 27, 2020
bwoodsend pushed a commit that referenced this pull request Dec 5, 2020
rokm pushed a commit to rokm/pyinstaller-hooks-contrib that referenced this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'prettytable' distribution was not found
3 participants