Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #8

Merged
merged 5 commits into from Jul 8, 2020
Merged

Add files via upload #8

merged 5 commits into from Jul 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2020

Added html test runner hook which fixes report generation when used with unit-testing

LP added 2 commits July 6, 2020 10:53
Added html test runner hook which fixes report generation when used with unit-testing
@ghost ghost requested review from a team and Legorooj and removed request for a team July 6, 2020 05:46
@ghost
Copy link
Author

ghost commented Jul 6, 2020

Added html test runner hook which fixes report generation when used with unit-testing

Copy link
Member

@Legorooj Legorooj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry. You can see the details on how in news/README.txt.

@Legorooj Legorooj mentioned this pull request Jul 7, 2020
@ghost
Copy link
Author

ghost commented Jul 7, 2020

Please add a changelog entry. You can see the details on how in news/README.txt.

I have added can you kindly check

Please add a changelog entry. You can see the details on how in news/README.txt.

I have Added .. Can you Kindly check ...

@htgoebel
Copy link
Member

htgoebel commented Jul 7, 2020

@Legorooj IMHO more important: The file is missing a copyright/license header.

@Legorooj
Copy link
Member

Legorooj commented Jul 7, 2020

@htgoebel thanks for pointing that out - probably would have spotted it next check but who knows?

@LP-codes please add the GPL header. This can be found in LICENSE.GPL.txt.

LP added 2 commits July 7, 2020 15:25
Add a hook for html-testRunner, which has a hidden import.
@Legorooj Legorooj merged commit 9196cac into pyinstaller:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants