Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added googleapiclient.discovery #97

Merged
merged 3 commits into from
Mar 12, 2021

Conversation

sirdeniel
Copy link
Contributor

Implements the fix commented here on #82.
TL;DR: Using google-api-python-client for Blogger API causes build() method to raise error and None value due to missing googleapiclient.discovery files.

@sirdeniel sirdeniel requested review from a team and Legorooj and removed request for a team March 11, 2021 05:10
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seriously doubt you need include_py_files=True. What happens if you get rid of it?

Also this needs a news entry.

@rokm
Copy link
Member

rokm commented Mar 11, 2021

What's probably needed here is to collect JSON files in site-packages/googleapiclient/discovery_cache/documents/, so include_py_files=True indeed looks redundant.

I suppose the data collection should go into separate hook, hook-googleapiclient.discovery.py instead of existing hook-googleapiclient.model.py to keep things consistent (or alternatively, hook-googleapiclient.model.py with proposed changes should be "upgraded" into hook-googleapiclient.py)?

@sirdeniel
Copy link
Contributor Author

I seriously doubt you need include_py_files=True. What happens if you get rid of it?

Also this needs a news entry.

I'll check this ASAP and comment here. Thanks for the suggestion as I'm noob to this.

@sirdeniel
Copy link
Contributor Author

What's probably needed here is to collect JSON files in site-packages/googleapiclient/discovery_cache/documents/, so include_py_files=True indeed looks redundant.

I suppose the data collection should go into separate hook, hook-googleapiclient.discovery.py instead of existing hook-googleapiclient.model.py to keep things consistent (or alternatively, hook-googleapiclient.model.py with proposed changes should be "upgraded" into hook-googleapiclient.py)?

You're right, my apologies for messing up the original script. I'll try my best to get an optimized way to get this done, I'd like some help on the road.

Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sirdeniel
Copy link
Contributor Author

To comment on the behavior, discarding include_py_files=True causes to import only the JSON files as suggested by @rokm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants