Issue with third level imports

[panaotizz]

Hi everyone,

Im sure this has been posted dozens of times and i searched through the issues but couldn't find a solution.

Im trying to build an executable that uses the 'meraki' module. Installer builds but then when i run the executable i get:

Traceback (most recent call last):
  File "main.py", line 7, in <module>
  File "PyInstaller\loader\pyimod03_importers.py", line 540, in exec_module
  File "meraki\__init__.py", line 5, in <module>
  File "PyInstaller\loader\pyimod03_importers.py", line 540, in exec_module
  File "meraki\rest_session.py", line 13, in <module>
  File "PyInstaller\loader\pyimod03_importers.py", line 540, in exec_module
  File "meraki\__init__.py", line 5, in <module>
ModuleNotFoundError: No module named 'meraki.__init__.rest_session'

I tried adding meraki, meraki.init and meraki.init.rest_session in the spec file and rebuilding but to no avail.

Any help would be appreciated

[bwoodsend]

What is line 7 of main.py? I guess it's some kind of import meraki but what is it exactly?

[rokm]

Hm, actually, I suspect this is the problematic line that causes meraki.__init__ to appear among the modules.

Changing that into absolute import (from meraki import __version__) and pushing __version__ above the imports in __init__.py seems to fix the problem.

[panaotizz]

is there anything i can do on my end or should i wait for a patch ?

Thank you so much for your replies!

[rokm]

You can modify your local meraki installation as described above.

[bwoodsend]

I didn't even think that that line would be legal in Python. Despite appearing to work, it's still not really correct. Looking at sys.modules, it has had to load __init__ twice, once as meraki (the normal behaviour) and once a submodule meraki.__init__ (which should never happen). @panaotizz I suggest you make a pull request to meraki to change this.

[rokm]

I suspect they ended up with that because it did not cause circular import error (which is why with proper from meraki import __version__ (or equivalent relative from . import __version__), __version__ in __init__.py needs to be pushed above local imports.

[panaotizz]

It is import meraki, yes

…

On 30 May 2021, at 17:24, Brénainn Woodsend ***@***.***> wrote:  What is line 7 of main.py? I guess it's some kind of import meraki but what is it exactly? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[panaotizz]

Thank you so much again, it worked perfectly. I will make a pull request to meraki

…

On 30 May 2021, at 18:36, Brénainn Woodsend ***@***.***> wrote:  I didn't even think that that line would be legal in Python. Despite appearing to work, it's still not really correct. Looking at sys.modules, it has had to load __init__ twice, once as meraki (the normal behaviour) and once a submodule meraki.__init__ (which should never happen). @panaotizz I suggest you make a pull request to meraki to change this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.