Preserve original PYTHONPATH in a different env-variable

[nebukadhezer]

Hello,

I hope this wont be mistaken with #187 .
But it sort means to have a way to access the old PYTHONPATH.
Egg
when I run my binary PYTHONPATH is erased and set to "/tmp/__XXXXX" to have the binary run selve contained, which makes total sense.
Still as we are using this for an app to set environments, I sometimes would like to append sth to the PYTHONPATH that existed prior to launching the binary.
Would it be possible to save the old PYTHONPATH from the envirnment somewhere, so one can choose to reuse it afterwards ?
like stuff it into PYINSTALLER_PYTHONPATH_OLD, sure if the PYTHONPATH is emtpy this should not happen...

Or is this impossible to do by design ?

-johannes

[htgoebel]

I'm afraid if we implement such a feature, people will use it and wonder why stuff is not working as expected. (Hmm, maybe we can use some ugly variable-name like ORIG_PYTHONPATH_THIS_MAY_BREAK_PYINSTALLER_BUNDLED_EXECUTABLE ;-)

As a work-around you could use a simple script (shell or .bat) preserving the original PYTHONPATH in a different variable.

[nebukadhezer]

Hi,
for the time being I am running the python code directly which works fine... in cases I need to append sth to PYTHONPATH.
It is up to you if you think it is a useful addition to the toolset, and I agree the name above should tip people of not to use it likely.

thanks for the fast answer and the wrapper idea.

Johannes

[htgoebel]

@matysek What do you think? I'm in favour of closing as "won't fix"

[codewarrior0]

I just noticed something goofy: PyInstaller sets the flag Py_IgnoreEnvironmentFlag, and then tries to use the PYTHONPATH environment to influence Python's initial sys.path. So our use of PYTHONPATH is a complete no-op.

We only set PYTHONPATH before calling Py_Initialize, and only on Python 2. But for Python 2, we don't even need to set sys.path before initializing (only Python 3 cares about that because it needs the encodings module from our base_library.zip). We override sys.path using C apis after initializing anyway.

This makes the fix very trivial indeed.

[codewarrior0]

Fixed in 968311e

PyInstaller no longer touches the PYTHONPATH environ.