Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing GTK theme support #3084

Closed
thekswenson opened this issue Dec 7, 2017 · 3 comments
Closed

Implementing GTK theme support #3084

thekswenson opened this issue Dec 7, 2017 · 3 comments

Comments

@thekswenson
Copy link

This ticket will be associated with the implementation of GTK theme support.
The goal is to import the files only for the current them, instead of all the themes.

My main motivation is to take care of the issue #3069 where a symbolic link is not collected in a way that it can be used by the frozen application.

@thekswenson
Copy link
Author

@htgoebel : I have implemented a fix and am wondering how to properly test it. I notice that the development branch fails many unit tests.

Should I just make sure no additional failures are induced by the new code?
Also, could you give me a hint on how you would like me to add new unit tests? The code depends on having links in the directory structure. Should I commit a test directory structure to the repo or something?

@stormbeforesunsetbee
Copy link

Guys, why don't we close this issue already, as now we have a better Gtk hook with icon, theme, and language options?

@bwoodsend
Copy link
Member

Agreed, theme limitation was done ages ago.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants