Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks: Get qmldir from Qml2ImportsPath for PySide2 #4136

Closed
wants to merge 1 commit into from
Closed

Hooks: Get qmldir from Qml2ImportsPath for PySide2 #4136

wants to merge 1 commit into from

Conversation

cbenhagen
Copy link
Contributor

Fixes #3689

@bjones1
Copy link
Contributor

bjones1 commented Apr 11, 2019

Thanks for your contribution. Would you:

  1. Add a changelog file named news/4136.bugfix.rst with a brief description of your changes (see https://pyinstaller.readthedocs.io/en/stable/development/changelog-entries.html for more info).
  2. Rebase this onto the current develop.

@bjones1 bjones1 self-assigned this Apr 11, 2019
@sjackso
Copy link

sjackso commented Apr 29, 2019

I have a client whose software depends on this fix -- I have them on a custom version right now, but I would like to help get this PR merged.

@bjones1 Is it okay if I open a new PR with @cbenhagen's patch, plus the changes you requested above, so that these changes may be applied?

@cbenhagen
Copy link
Contributor Author

Sorry I must have missed the notification. Yes please go ahead!

@sjackso sjackso mentioned this pull request Apr 29, 2019
Closed
@bjones1
Copy link
Contributor

bjones1 commented May 12, 2019

This was fixed in 5b57912. Please reopen if there are still problems.

@bjones1 bjones1 closed this May 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bjones1 bjones1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'exec_command' from 'PyInstaller.utils.hooks'
3 participants
@cbenhagen @bjones1 @sjackso