Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools extra_requires for easy --key dependency install #4904

Closed
johnthagen opened this issue May 31, 2020 · 4 comments
Closed

Add setuptools extra_requires for easy --key dependency install #4904

johnthagen opened this issue May 31, 2020 · 4 comments
Labels
feature Feature request

Comments

@johnthagen
Copy link
Contributor

Currently the README says:

https://github.com/pyinstaller/pyinstaller#requirements-and-tested-platforms

Python:
- 3.5-3.7
- tinyaes 1.0+ (only if using bytecode encryption)

Which was updated in #4652.

setuptools.extra_requires could be used to simplify installing this optional depedency for the user.

This could be done by modifying setup.py similar to:

setup(
    ...
    extras_require={
        "encryption":  ["tinyaes>=1.0.0"],
    }
)

And then users could install / add to requirements.txt:

$ pip install pyinstaller[encryption]
@johnthagen johnthagen added the feature Feature request label May 31, 2020
@Legorooj
Copy link
Member

Legorooj commented May 31, 2020

Nice idea. I'll add this today.

@johnthagen
Copy link
Contributor Author

Just curious, do you know when a release will be produced with this new tinyaes support? Looks really nice for users.

@Legorooj
Copy link
Member

Legorooj commented Jun 1, 2020

@johnthagen the plan is the 4.0 milestone. Then we'll release.

@Legorooj
Copy link
Member

Legorooj commented Jun 1, 2020

Added in 15ecf74. Notes to doc and README added as well.

@Legorooj Legorooj closed this as completed Jun 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants