loader: prevent local directory from shadowing system library #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a system dynamic library via ctypes.CDLL() in a frozen progam, a local directory in sys._MEIPASS with a clashing basename ends up preventing the library from being loaded. To fix this, use an os.path.isdir() to decide whether to use frozen or original library name. Fixes pyinstaller#5178.
Legorooj
approved these changes
Sep 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a system dynamic library via
ctypes.CDLL()in a frozen progam, a local directory insys._MEIPASSwith a clashing basename ends up preventing the library from being loaded.To fix this, use
os.path.isdir()in addition toos.path.exists()to decide whether to use frozen or original library name.Fixes #5178.