hooks: qt: prevent potential error due to partially-installed PyQt6 #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent potential errors on importing PyInstaller.utils.hooks.qt module, caused by a partial PyQt6 installation (e.g., only PyQt6-Qt6 and PyQt6-sip remaining installed after user uninstalls PyQt6 package).
|
This change is similar to the one in #6114 for PyQt5, but in this case the underlying reason is a bit different (although now that I think about it, one could end up with similar partial installation of PyQt5 as well). |
bwoodsend
approved these changes
Aug 21, 2021
rokm
added a commit
that referenced
this pull request
Aug 22, 2021
…6141) Prevent potential errors on importing PyInstaller.utils.hooks.qt module, caused by a partial PyQt6 installation (e.g., only PyQt6-Qt6 and PyQt6-sip remaining installed after user uninstalls PyQt6 package).
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent potential errors on importing
PyInstaller.utils.hooks.qtmodule, caused by a partialPyQt6 installation(e.g., onlyPyQt6-Qt6andPyQt6-sipremaining installed after user uninstallsPyQt6package). As the error is raised on import of theqthookutils module, it then affects all hooks for all Qt-based packages (not justPyQt6).