hooks: qt: update hooks for PySide6/PyQt6 v6.5.0 #7549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hooks for `PySide6.QtLocation` and `PySide6.QtSerialBus` that are available in 6.5.0, and update corresponding module definitions. Also mark `QtPositioning` python module as available on all bindings, since that seems to be the case (and has been for a while?). As a side note, the preview of `PyQt6` 6.5.0 does not seem to provide `QtLocation` nor `QtSerialBus` python modules (nor the corresponding Qt shared libraries), so no change need to be made for `PyQt6` yet.
Add dynamic check for SSL support, and skip the test if it is not available (e.g., `QtNetwork` in `PySide6` 6.5.0 requires OpenSSL 3, which is unavailable on `ubuntu-20.04` GA runner). Also, have the test instantiate `QCoreApplication` to avoid a warning.
The python module for QtTextToSpeech seems to be added in PyQt6 6.4.0 and PySide6 6.5.0. The hooks ensure that plugins are collected.
PySide6 6.5.0 PyPI wheels seem to be missing `opengl32sw.dll`, which causes `QtWebEngine` applications in virtualized environments to crash due to failure to initialize OpenGL context.
Looks like passing an empty list is causing problems with QtWebEngine in PyQt6 6.5.0. And even if we can get away with it in other tests and with other bindings, it makes more sense to properly pass `sys.argv`, as one would in a real application. Applies to all instantiations of `QCoreApplication`, `QGuiApplication`, and `QApplication`.
Instantiate `QCoreApplication` with `sys.argv` instead of an empty list to avoid potential issues in the future.
The python module for QtSpatialAudio was added in PyQt6 6.5.0.
rokm
changed the title
bwoodsend
approved these changes
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update module definitions and add hooks for
PySide6.QtLocation,PySide6.QtTextToSpeech, andPySide6.QtSerialBus, which were added in PySide6 6.5.0.Add hook for
PyQt6.QtTextToSpeech, which was introduced in PyQt6 6.4.x, and apparently flew under our radar because the basic import test works without the hook as well (the hook ensures that plugins are collected).In
test_QtNetwork_SSL_supportwe now first run a subpprocess to check ifQtNetworkactually supports SSL; this is becauseQtNetworkin linux wheels for PySide6 6.5.0 requires OpenSSL 3, which is not available on theubunut-20.04runner that we use.The
QtWebEnginein PySide6 6.5.0 seems to be broken in virtualized environments due to lack ofopengl32sw.dllin the Windows wheels. I've lodged a complaint (https://bugreports.qt.io/browse/PYSIDE-2289) to see if this is intentional, but in the meantime, we should skip those tests on Windows.... and since apparently PyQt6 6.5.0 was released this morning, add the missing hook for
PyQt6.QSpatialAudioand ensure that all our tests instantiateQCoreApplication/QGuiApplication/QApplicationwithsys.argvinstead of an empty list, since the empty list seems to cause problems withQtWebEngineinPyQt66.5.0.