building: limit package import in binary dependency analysis to Windows #7698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the collected package import in the binary dependency analysis subprocess (performed prior to the actual analysis) to Windows. Windows is the only platform where the packages' initialization code can modify shared library search paths (either by modifying `PATH` environment variables, or by calling `os.add_dll_search_path`), so importing the collected packages to initialize the environment makes sense only there. Furthermore, non-deterministic package import order may cause issues with particular package combinations and import orders, so it is better to avoid it where we do not need it (i.e., on non-Windows platforms).
bwoodsend
approved these changes
Jun 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the collected package import in the binary dependency analysis subprocess (performed prior to the actual analysis) to Windows.
Windows is the only platform where the packages' initialization code can modify shared library search paths (either by modifying
PATHenvironment variables, or by callingos.add_dll_search_path), so importing the collected packages to initialize the environment makes sense only there.Furthermore, non-deterministic package import order may cause issues with particular package combinations and import orders, so it is better to avoid it where we do not need it (i.e., on non-Windows platforms).
Closes #7695.