Add Nvidia libraries to Unix exclusion list #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Please add a news fragment for the changelog, and then we're good to merge. (I suppose the change could be classified as either |
|
Done. I went with As a historical note to anyone who might be reading this PR because they're stuck with Python 3.7, if you want to update the exclusion list at runtime, you need to change not only the |
bwoodsend
approved these changes
Jul 1, 2023
bwoodsend
pushed a commit
to bwoodsend/pyinstaller
that referenced
this pull request
Aug 26, 2023
While packaging an application that uses pynvml on Linux, the library libnvidia-ml.so.1 may be bundled into the resulting application. This library is part of the Nvidia driver stack and this behavior creates an incompatibility if the packaging system and runtime system do not have the same driver version (or are compatible in some vague sense I don't understand). For my application and I assume pretty much every application that might want to bundle pynvml this way, libnvidia-ml.so.1 should be excluded from the final distribution.
bwoodsend
pushed a commit
that referenced
this pull request
Aug 26, 2023
While packaging an application that uses pynvml on Linux, the library libnvidia-ml.so.1 may be bundled into the resulting application. This library is part of the Nvidia driver stack and this behavior creates an incompatibility if the packaging system and runtime system do not have the same driver version (or are compatible in some vague sense I don't understand). For my application and I assume pretty much every application that might want to bundle pynvml this way, libnvidia-ml.so.1 should be excluded from the final distribution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds several Nvidia libraries to PyInstaller's list of excluded libraries, which fixes the issue reported in #7745 in the manner suggested by @rokm.
The libraries added by this PR are a subset of what is listed in the Nvidia driver documentation for one of the recently release driver versions as of the time of this PR. I did check some historical versions and though there are a few libraries present in older drivers that are not covered by this change, the libraries listed here seem to be stable features of the stack.
Note that I have explicitly left out any libraries related to CUDA or OpenCL which are reasonably likely candidates for inclusion in a PyInstaller application, and which have decent forward compatibility as far as I know.
The specific case that led me to file this PR and which I used to test its efficacy is a PyInstaller application that has a dependency
pynvml, which induces a dependency (viactypes) onlibnvidia-mlthat can cause mismatches if the application is run on a system with a different driver version than the system that built the PyInstaller distribution.