Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from 5.13.0 to 5.13.1 results in crash of Python 3.8 32bit build #7897

Closed
Safihre opened this issue Aug 28, 2023 · 5 comments
Closed
Labels
triage Please triage and relabel this issue

Comments

@Safihre
Copy link
Contributor

Safihre commented Aug 28, 2023

We build SABnzbd with nice recent 64bit Python 3.11.5, but also with Python 3.8 32bit so we can release a "legacy" version that still runs on Windows 7 and on the few 32 bit systems out there. We've been doing this for quite a while and all is well.

However, Renovate triggered an update of PyInstaller to 5.13.1 from 5.13.0 and now suddenly the Python 3.8 32 bit build fails because it runs beyond the build limit of 30 minutes. Normally the build of both releases combined completes within 5-10 minutes.

  1. 5.13.1 build
  2. 5.13.0 build that I re-triggered just to confirm it's not some GitHub Actions issue.

I'm not sure if it's Python 3.8 or 32bit that is causing the issue.

@Safihre Safihre added the triage Please triage and relabel this issue label Aug 28, 2023
@rokm
Copy link
Member

rokm commented Aug 28, 2023

Considering the last output from PyInstaller is 41354 INFO: Building COLLECT COLLECT-01.toc completed successfully. (which is the same as in "good" 5.13.0 build) and you are using a custom build script, can you add a debug message to your build script after the PyInstaller process is ran? I.e., so we can see if the build script is stuck in PyInstaller process for whatever reason, or if the PyInstaller process has finished and the build script is stuck somewhere else?

@rokm
Copy link
Member

rokm commented Aug 28, 2023

Since this is 32-bit python on Windows, perhaps #7893 is manifesting in some way? Are you trying to run the generated executable somewhere during the build process?

@bwoodsend
Copy link
Member

It does test it. https://github.com/sabnzbd/sabnzbd/blob/77518cf1f5eb1162ed0634c6f1f16d4d70df6822/builder/package.py#L266

Presumably, that's crashing and creating a blocking error dialog.

@Safihre
Copy link
Contributor Author

Safihre commented Aug 29, 2023

Since this is 32-bit python on Windows, perhaps #7893 is manifesting in some way? Are you trying to run the generated executable somewhere during the build process?

Seems you are right.
I disabled the release-check to get a successful build and it fails to run:

Traceback (most recent call last):
  File "Lib\site-packages\PyInstaller\hooks\rthooks\pyi_rth_win32comgenpy.py", line 46, in <module>
  File "Lib\site-packages\PyInstaller\hooks\rthooks\pyi_rth_win32comgenpy.py", line 31, in _pyi_rthook
  File "PyInstaller\fake-modules\_pyi_rth_utils\__init__.py", line 43, in secure_mkdtemp
  File "PyInstaller\fake-modules\_pyi_rth_utils\_win32.py", line 234, in secure_mkdir
OSError: exception: access violation reading 0x00000010

So, wait for 5.13.2 it seems?

@Safihre Safihre changed the title Update from 5.13.0 to 5.13.1 results in extreme slowdown of Python 3.8 32bit build Update from 5.13.0 to 5.13.1 results in crash of Python 3.8 32bit build Aug 29, 2023
@Safihre
Copy link
Contributor Author

Safihre commented Aug 29, 2023

Guess we can close as duplicate of #7893!

@Safihre Safihre closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage Please triage and relabel this issue
Projects
None yet
Development

No branches or pull requests

3 participants