bootloader: onefile: set executable bit only on extracted binaries #7950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extracting files from onefile archive, restore the executable bits only on binary files (those that were collected with TOC type codes `EXECUTABLE`, `BINARY`, or `EXTENSION˙, which all end up having PKG type code `b`), as opposed to all files. Binaries are now extracted with permissions bit set to `0700`, while other files are extracted with permissions bit set to `0600`.
rokm
force-pushed
the
bootloader-onefile-executable-bit
branch
from
fe8ace8
to
91a8fe3
Compare
rokm
changed the title
Add a test to ensure that we preserve the executable bit on collected shell script (a data file with executable bit set).
bwoodsend
approved these changes
Sep 22, 2023
Add special handling for data files with executable bit set (such
as shell scripts).
In `COLLECT` and `BUNDLE`, we now set mode `0755` if typecode
matches the one for binary type OR if the source file has an
executable bit set.
In `PKG`, we manually force the PKG typecode for DATA entries to
`b` ("binary") if source file has an executable bit set.
rokm
force-pushed
the
bootloader-onefile-executable-bit
branch
from
1a65dfa
to
227b648
Compare
bwoodsend
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting files from onefile archive, restore the executable bits only on binary files (those that were collected with TOC type codes
EXECUTABLE,BINARY, orEXTENSION˙, which all end up having PKG type codeb`), as opposed to all files.Binaries are now extracted with permissions bit set to
0700, while other files are extracted with permissions bit set to0600.This synchronizes
onefilemode withonedirmode in terms of files that end up with executable bit being set.