analysis: automatically exclude macOS .DS_Store files #8042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
force-pushed
the
exclude-ds-store-files
branch
from
6490aff
to
da759fe
Compare
On macOS, have Analysis automatically filter `.DS_Store` files from `datas` TOC list. These files might be present in package directories as result of user navigating them in the Finder app. The `.DS_Store` files are treated as data files, so when placed in a mixed-content directory (i.e., next to binaries), the `BUNDLE` generator cross-links them from `Resources` to `Frameworks` directory tree in the .app bundle. This, however, causes `codesign` to raise the following error: `.DS_Store files cannot be a symlink`. Since we have no reason to be collecting Finder's `.DS_Store` files in the first place, filter them out at the end of analysis.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, have Analysis automatically filter
.DS_Storefiles fromdatasTOC list. These files might be present in package directories as result of user navigating them in the Finder app.The
.DS_Storefiles are treated as data files, so when placed in a mixed-content directory (i.e., next to binaries), theBUNDLEgenerator cross-links them fromResourcestoFrameworksdirectory tree in the .app bundle. This, however, causescodesignto raise the following error:.DS_Store files cannot be a symlink.Since we have no reason to be collecting Finder's
.DS_Storefiles in the first place, filter them out at the end of analysis.