hooks: exclude docutils from distutils.command.check #8053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bwoodsend
approved these changes
Oct 31, 2023
Add hooks for `distutils.command.check` from stdlib and `setuptools` (`setuptools._distutils.command.check`) that exclude conditionally-imported `docutils`. The latter is quite heavy-weight, as it triggers collection of various modules from `pygments` and `PIL`; so try avoiding its collection if not necessary. See: https://github.com/python/cpython/blob/v3.8.0/Lib/distutils/command/check.py#L8-L34 https://github.com/pypa/setuptools/blob/v68.2.2/setuptools/_distutils/command/check.py#L10-L36
rokm
force-pushed
the
hook-distutils-exclude-docutils
branch
from
9255223
to
99927ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hooks for
distutils.command.checkfrom stdlib andsetuptools(setuptools._distutils.command.check) that exclude conditionally-importeddocutils.The latter is quite heavy-weight, as it triggers collection of various modules from
pygmentsandPIL; so try avoiding its collection if not necessary.See:
https://github.com/python/cpython/blob/v3.8.0/Lib/distutils/command/check.py#L8-L34
https://github.com/pypa/setuptools/blob/v68.2.2/setuptools/_distutils/command/check.py#L10-L36