pre-safe-import-hooks: gracefully handle cases when six is unavailable #8145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pre-safe-import hooks that deal with
six
(or vendoredsix
), gracefully handle the cases when thesix
module is unavailable.In general, the pre-safe-import hooks might end up being called for non-existent modules, and the hooks need to account for that (even though the behavior seems to depend on how the missing module is imported).
For example, a program with a duplicated import,
seems to end up triggerring the
six.moves
pre-safe-import hook on the second import. The same happens in more complex scenarios where these imports are scattered across different modules.