Optimize binary vs. data reclassification on Linux #8148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Before running the automatic binary-vs-data reclassification, display an INFO message. Otherwise, the user might get an impression that the process got stuck while loading the last hook in (pathological) cases when reclassification takes a while. This way, they know which part of the process to blame.
Avoid running `objdump` on every file, as that becomes prohibitively costly for projects with a lot of (data) files. First, perform a check for 4-byte ELF header to filter out most (if not all) data files; only then, validate the likely binary using `objdump` to ensure that it is a valid ELF file.
bwoodsend
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid running
objdumpon every file, as that becomes prohibitively costly for projects with a lot of (data) files.First, perform a check for 4-byte ELF header to filter out most (if not all) data files; only then, validate the likely binary using
objdumpto ensure that it is a valid ELF file.