Misc. smaller changes #8279
Merged
Misc. smaller changes #8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augment displayed the PyInstaller version with version of the `pyinstaller-hooks-contrib` package.
Update ruff settings in `pyproject.toml` to fix deprecation warnings with `ruff` 0.2.0.
When trying to run PyInstaller against non-existent script file(s), exit with error message immediately, before writing the spec file and trying to build it. This prevents us from overwriting an existing (and customized) .spec file if user makes a typo in the .spec file's suffix when trying to build it, for example, `pyinstaller program.cpes`. It also prevents creation of a .spec file when `pyinstaller program.py` is accidentally ran from a directory that does not contain the script (for example, due to failing to change the directory prior to running the command). This applies only to the `pyinstaller` command (and the equivalent `python -m PyInstaller` invocation); the `pyi-makespec` command is still allowed to be called with non-existent script file(s) that might be added later, before the actual build attempt with the generated .spec file.
bwoodsend
approved these changes
Feb 3, 2024
I could start doing this as part of the release process? |
Good idea. I'll drop the corresponding commit here, then, and you can bump the version prior to next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous smaller changes based on this week's issue tracker activity:
display version of
pyinstaller-hooks-contribnext to PyInstaller version at program start, to make it easier to determine the user's actual setupwhen trying to run
pyinstaller(or equivalentpython -m PyInstaller) against non-existing script file(s), exit immediately - without trying to write the .spec file and building it. Mainly to avoid scenario with overwriting a customized .spec file due to typo in command's arguments (PyInstaller poiting to wrong spec file #8276), but also because I sometimes fail to change the directory prior to trying to build a test program, and then have to deal with stay .spec files.fix deprecation warnings emitted by
ruff0.2.0bump the required
pyinstaller-hooks-contribversion to the latest release, in attempt to minimize amount of issues reported due to old hooks.