building: collect .hmac files for linux shared libraries #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the late analysis stage, go over all collected binaries, and collect their accompanying .hmac files, if they are available. These files are required in FIPS-enabled mode on RHEL, where the HMAC accompanying OpenSSL shared library is used in the library's self-check.
On FIPS-enabled RHEL systems, `hashlib.md5()` raises exception: ``` ValueError: [digital envelope routines: EVP_DigestInit_ex] disabled for FIPS ``` So switch to SHA1 instead.
Remove the check for WinSxS `.manifest` files in `process_collected_binaries` helper, as automatic data vs binary (re)classification should hopefully ensure that `.manifest` files never end up in this processing codepath.
Refactor `process_collected_binary` helper, with goal of removing the recursive call to itself when both strip and upx are enabled. This makes the processing flow easier to follow, and makes it easier to add additional steps (for example, code-signing on Windows), without having to worry about those steps being performed in intermediate recursive calls.
Automatically disable upx and/or strip if a linux binary has an accompanying .hmac file, as modification to the binary will invalidate the HMAC.
If calling `strip` or `upx` in `process_collected_binary` fails for whatever reason, display a warning and captured stdout/stderr. The failure is still considered non-fatal (warning instead of an error), but it should be visible to the user.
bwoodsend
approved these changes
Feb 7, 2024
rokm
added a commit
to rokm/pyinstaller
that referenced
this pull request
Feb 22, 2024
Extend the mechanism for collection of `.hmac` files from pyinstaller#8288 to `.chk` files that are used by NSS libraries.
rokm
added a commit
that referenced
this pull request
Feb 23, 2024
Extend the mechanism for collection of `.hmac` files from #8288 to `.chk` files that are used by NSS libraries.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement collection of
.hmacfiles that may accompany shared library.sofiles on some linux systems (Red Hat Enterprise Linux, Fedora Linux). As per #8287, these HMACs are used in crypto library validation/self-check that is enforced when RHEL system is running in FIPS-enabled mode:https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/security_hardening/assembly_installing-a-rhel-8-system-with-fips-mode-enabled_security-hardening
Closes #8273.
When running in FIPS-mode,
hashlib.md5()cannot be used - therefore, switch the binary cache hashes from md5 to sha1. This allows to run PyInstaller with--stripoption on FIPS-enabled RHEL system.A shared library with HMAC should not be modified in any way (as this invalidates the HMAC), so exempt such shared libraries from processing in
process_collected_binaries(strip and/or upx, although upx is currently disabled on linux).At the same time, refactor
process_collected_binariesto remove call to itself when both strip and upx are used; instead, both utilities are called one after another (i.e., without separately caching the intermediate result). The main goal here is to simplify the processing flow to make it easier to eventually introduce support for code-signing on Windows.