Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the pyi_rth_win32comgenpy #8313

Merged
merged 2 commits into from Feb 21, 2024

Conversation

arossert
Copy link
Contributor

Following this discussion https://github.com/orgs/pyinstaller/discussions/8309 it was decided to remove this hook

@bwoodsend
Copy link
Member

Just needs a news entry. Not sure what it would be though. Remove obsolete redirection of win32com's cache to a temporary directory?

@rokm
Copy link
Member

rokm commented Feb 20, 2024

Just needs a news entry. Not sure what it would be though. Remove obsolete redirection of win32com's cache to a temporary directory?

Remove run-time hook for ``win32com``, as per discussion in issue:`8309`.

should suffice, I think.

@arossert
Copy link
Contributor Author

@rokm Should it be a feature, bugfix, or breaking?

@rokm
Copy link
Member

rokm commented Feb 20, 2024

@rokm Should it be a feature, bugfix, or breaking?

I'd put it under hooks.

Signed-off-by: Amir Rossert <amir.rossert@safebreach.com>
@bwoodsend bwoodsend enabled auto-merge (squash) February 20, 2024 21:06
@bwoodsend bwoodsend merged commit 2d38dc8 into pyinstaller:develop Feb 21, 2024
18 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants