tests: bump PySide6 to 6.7.0 and update PySide6 hooks #8404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump PySide6 to 6.7.0. For python 3.8, we need to stick with 6.6.3.1, as 6.7.0 dropped support for it.
In PySide6 6.7.0, `PySide6.Qt3DRender` module added a reference to type system of `PySide6.QtOpenGL` module, so we need to add a hidden import for OSes where the `PySide6.QtOpenGL` module is not picked up automatically; i.e., on Windows, where the `Qt6OpenGL` shared library does not appear in the binary dependency tree of the `PySide6.Qt3DRender` module.
bwoodsend
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like PySide6/Qt6 6.7.0 is quite benign from our perspective; only thing that needs to be fixed is adding a hidden import of
PySide6.QtOpenGLto thePySide6.Qt3DRenderhook, to fix tests that import individual modules.