Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task dependencies #41

Closed
bitprophet opened this issue Feb 5, 2013 · 4 comments
Closed

Task dependencies #41

bitprophet opened this issue Feb 5, 2013 · 4 comments

Comments

@bitprophet
Copy link
Member

🚨 TODO: copy in stuff from the Fabric ticket 🚨

Might be nice to have the API for "I depend on these other tasks running first" be *args in @task, e.g. @task(other1, other2, kwargs=here). Make-like, simple, *args aren't sensible otherwise (e.g. to call the existing things intended to be kwargs). Props to @mattrobenolt for the idea.

@bitprophet
Copy link
Member Author

Pre-tasks are now implemented using an Executor class, which should also form the basis for post-tasks/parameterization/parallelization/etc.

Still using the *args shortcut as per above & as per Matt's earlier PR.

@bitprophet
Copy link
Member Author

Still need to implement the now-in-doc deduping of tasks too.

@bitprophet
Copy link
Member Author

Deduping is in! For now, used a dedupe bool kwarg to Executor.execute (vs using a distinct subclass) but I'm sure this will adapt as we go, especially re #45.

That set of changes also (as with Matt's earlier PR) implements a (basic, not preserving any metadata) Task.__call__.

@bitprophet
Copy link
Member Author

Implemented --no-dedupe in basic form, calling this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant