Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyiron_workflow depends on pyiron_atomistics and pyiron_base leading to a large number of dependencies #46

Open
srmnitc opened this issue Oct 23, 2023 · 5 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@srmnitc
Copy link
Member

srmnitc commented Oct 23, 2023

Summary

pyiron_workflow depends on pyiron_atomistics and pyiron_base, which in turn depends on a large number of packages. This makes the workflow package rather heavy for a user who might want to use it solely to leverage the power of workflows. Would it make sense to release the dependencies and make this package rather light weight?

@srmnitc srmnitc added bug Something isn't working dependencies Pull requests that update a dependency file and removed bug Something isn't working labels Oct 23, 2023
@liamhuber
Copy link
Member

Absolutely. There's a clear path for this too, it just hasn't been high priority.

Our dependency on pyiron_base is currently just logger and Singleton. These could be git-copied over here, or (better IMO) we can start a new repo of standard-libarary-only-depenency pyiron tools as discussed in this issue over on base.

Our dependency on pyiron_atomistics is only for actual individual nodes, and not in the infrastructure. At the latest when the node_library submodule gets pulled out/broken apart into node library module(s), we'll lose this dependency. We can probably make it optional even before then by moving the import inside the individual node functionalities.

@liamhuber
Copy link
Member

This was resolved and both those packages are out of the dependency stack, buuuut, I'm probably about to add base back in in order to get storage rolling, so I'll leave this open.

@liamhuber
Copy link
Member

This was resolved and both those packages are out of the dependency stack, buuuut, I'm probably about to add base back in in order to get storage rolling, so I'll leave this open.

Nope, we'll just move tinybase here, per #161. So this is out, the dependency is strictly for the node libraries that depend on those modules.

@liamhuber
Copy link
Member

#160 introduces pyiron_contrib dependency, although it's not planned to stay this way. I'm re-opening to keep track of the shortcoming.

@liamhuber liamhuber reopened this Jan 20, 2024
@liamhuber
Copy link
Member

I'm also slapping on boto3 as long as contrib is not playing nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants