Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template #20

Closed
theSage21 opened this issue Jan 15, 2019 · 12 comments
Closed

Pull request template #20

theSage21 opened this issue Jan 15, 2019 · 12 comments
Labels
good first issue Good for newcomers

Comments

@theSage21
Copy link
Member

Since people are opening pull requests now, it's becoming irritating to manually close issues which the PR solves. A Pull request template will solve this.

Refer to github docs on PR templates and add a template. The template should ask the person to mention the issue that they are trying to solve. Then when the PR is merged, the issue is closed automatically.

@theSage21 theSage21 added the good first issue Good for newcomers label Jan 15, 2019
@soumilk
Copy link
Member

soumilk commented Jan 15, 2019

I want to take this issue

@anjalijain1998
Copy link

I also want to work on this issue

@theSage21
Copy link
Member Author

maybe one of you could a pull request template and another one could do an issue template?

@anjalijain1998
Copy link

sure i am going for pull request template

@soumilk
Copy link
Member

soumilk commented Jan 15, 2019

@theSage21 please clarify Issue template? How this template is supposed to !

@theSage21
Copy link
Member Author

You can have a simple issue template like so:

  1. Please define your issue clearly
  2. Add a label if it is appropriate

@soumilk
Copy link
Member

soumilk commented Jan 15, 2019

ohk ... got it

@theSage21
Copy link
Member Author

@anjalijain1998 we will keep the issue open until you submit a PULL_REQUEST template code change. Please make sure to remind people to refer to issue in the PR so that they will be auto closed. reference

@anjalijain1998
Copy link

@theSage21 sir I have made this file but now what I have to do ?
please check it and let me know if I have done it correct or not!!

PULL_REQUEST_TEMPLATE.md.txt

@theSage21
Copy link
Member Author

Please don't call me sir. Arjoonn or @theSage21 is fine.

The file looks wonderful 👍

Open up a Merge request

@theSage21
Copy link
Member Author

I think you will have to call the file PULL_REQUEST_TEMPLATE.md and remove the .txt in the end. If you are on windows those extensions might be missing. This link might help you see those. Then just remove the .txt part from the file.

@anjalijain1998
Copy link

ohk sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Simple Web Server
Awaiting triage
Development

No branches or pull requests

3 participants