Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF] darglint is archived -> move to ruff? #1236

Closed
thatlittleboy opened this issue Jan 30, 2023 · 1 comment · Fixed by #1294
Closed

[INF] darglint is archived -> move to ruff? #1236

thatlittleboy opened this issue Jan 30, 2023 · 1 comment · Fixed by #1294
Labels
infrastructure Infrastructure-related issues

Comments

@thatlittleboy
Copy link
Contributor

thatlittleboy commented Jan 30, 2023

While working on #1235, I've experienced darglint to be really slow (takes minutes to run for the functions/pivot.py file), and also the project has been archived as of Dec 16 2022.

https://github.com/terrencepreilly/darglint/

We should transition to using ruff, which also provides darglint rules.

In which case, perhaps we can also drop flake8 in favour of ruff.

EDIT:

oops, I misremembered. darglint is not covered by ruff yet, but it's in the works. astral-sh/ruff#458

@ericmjl
Copy link
Member

ericmjl commented Oct 8, 2023

@thatlittleboy I am going to switch our infra over to ruff. Thanks for raising this issue, and oh my, I just realized I've really neglected our shared project for a long time. (Work has been craaaazy.)

@ericmjl ericmjl mentioned this issue Oct 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants