Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add "missing data" viz to example notebooks #4

Closed
ericmjl opened this issue Mar 11, 2018 · 9 comments
Closed

[DOC] Add "missing data" viz to example notebooks #4

ericmjl opened this issue Mar 11, 2018 · 9 comments
Labels
available for hacking This issue has not been claimed by any individual. docfix Documentation fixes needed good first issue Good for newcomers

Comments

@ericmjl
Copy link
Member

ericmjl commented Mar 11, 2018

This is quite important. I'd like to wrap other packages rather than invent the wheel. One possible package is to wrap missingno with a user-friendly API.

@ericmjl ericmjl added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 11, 2018
@souravsingh
Copy link

I am willing to work on this.

@ericmjl
Copy link
Member Author

ericmjl commented Mar 30, 2018

Thanks @souravsingh! Looking forward to the PR.

@JoshuaC3
Copy link
Contributor

JoshuaC3 commented May 24, 2018

I assume there has been no PR for this? If so, I am happy to pick this up if still desired.

My only question is, how would this differ from just using missingno itself? What added functionality would we like to see? Thanks :)

@ericmjl
Copy link
Member Author

ericmjl commented May 24, 2018

@JoshuaC3 thanks for pinging in on this one! At the moment, I haven't had the bandwidth to give this more thought, so I'm very open to discussing the most appropriate use cases. What ideas do you have?

A few points I can think off the top of my head right now that might be relevant:

  1. Janitor DataFrames inherit directly from Pandas dataframes and merely add in data cleaning convenience methods, so janitorDFs and pandasDFs are extremely compatible.
  2. One thought that I ever once had was "just wrap missingno" --> the key thing that Janitor provides is method chaining, BUT method chaining might not be a relevant pattern for data sanity checks.

@JoshuaC3
Copy link
Contributor

JoshuaC3 commented May 24, 2018

IMO, I prefer using the .pipe method on janitor function, as opposed to the jn.DataFrame with methods so this doesn't seem 100% natural to me. That said, I use the df.plot functionality a lot.

Also, missingno is already very easy to use,

import missingno as mn
mn.matrix(df)

This can be piped as well,

df.pipe(mn.matrix)

Thinking about this, I makes most sense to add this if we wish to extend functionality. I will have a think about how we could do this in janitor and post back.

@ericmjl
Copy link
Member Author

ericmjl commented May 27, 2018

This can be piped as well,
df.pipe(mn.matrix)

Oooh cool stuff! I didn't realize that, actually. Thanks for sharing this!

@ericmjl
Copy link
Member Author

ericmjl commented May 8, 2019

@JoshuaC3 I think this should be shown inside an example Jupyter notebook! What do you think? We have a bunch of notebooks already present, and can show how we go from data that is dirty (and has nullity) to data that is clean and densely populated!

@ericmjl ericmjl changed the title Adding in missing data visualization [DOC] Add missing data viz to example notebooks May 8, 2019
@ericmjl ericmjl added available for hacking This issue has not been claimed by any individual. docfix Documentation fixes needed and removed help wanted Extra attention is needed labels May 8, 2019
@ericmjl ericmjl changed the title [DOC] Add missing data viz to example notebooks [DOC] Add "missing data" viz to example notebooks Jul 12, 2019
@dancassin
Copy link
Contributor

Once the PR #6 in pyjanitor-examples is accepted, then I believe this issue can be closed as well.

@ericmjl ericmjl closed this as completed May 2, 2022
@ericmjl
Copy link
Member Author

ericmjl commented May 2, 2022

Thank you, @dancassin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available for hacking This issue has not been claimed by any individual. docfix Documentation fixes needed good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants