Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail for pull requests #171

Open
hugovk opened this issue Apr 23, 2016 · 0 comments
Open

Tests fail for pull requests #171

hugovk opened this issue Apr 23, 2016 · 0 comments
Labels
test Unit tests, linting, CI, etc.

Comments

@hugovk
Copy link
Member

hugovk commented Apr 23, 2016 •
edited

It's because of the secret environment variables which Travis CI disables for PRs for security reasons.

Options:

  • Mock network calls using something like vcrpy: Tests: mock network calls #105
  • Skip tests on "Invalid API key - You must be granted a valid key by last.fm"
  • Disable Travis CI for PRs
  • Just make those variables public
  • Something else?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Unit tests, linting, CI, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hugovk