Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consecutive frame timeout not raised after a Flow Control triggered by block size. #63

Closed
pylessard opened this issue Mar 6, 2022 · 1 comment · Fixed by #64
Closed

Consecutive frame timeout not raised after a Flow Control triggered by block size. #63

pylessard opened this issue Mar 6, 2022 · 1 comment · Fixed by #64
Assignees
@pylessard
Labels
bug
Projects
v1.8

Comments

@pylessard
Copy link
Owner

Consecutive frame timeout is not triggered if the sender stops sending after a flow control is sent, only if the flow control is triggered by the block counter that reaches its maximum. This does not happen after a flow control that follows a first frame.

ISO-15765:2016 specifies that it should be

image
@pylessard pylessard self-assigned this Mar 6, 2022
@pylessard pylessard added the bug label Mar 6, 2022
@pylessard pylessard added this to In Progress in v1.8 Mar 6, 2022
@pylessard pylessard mentioned this issue Mar 6, 2022
Closed
@pylessard
Copy link
Owner Author

This was raised by #41, but it was fixed only for flow control that follows a first frame.

@pylessard pylessard linked a pull request Mar 6, 2022 that will close this issue
CF timeout correctly raised if transmission is stopped after a flow control is issued #64
Merged
@pylessard pylessard moved this from In Progress to Done in v1.8 Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylessard pylessard

Labels
bug
Projects
No open projects
v1.8
Done
Milestone
No milestone
1 participant
@pylessard