Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponsePending is process but still produces a timeout #20

Closed
XelaRellum opened this issue Feb 20, 2019 · 2 comments
Closed

ResponsePending is process but still produces a timeout #20

XelaRellum opened this issue Feb 20, 2019 · 2 comments

Comments

@XelaRellum
Copy link

After receiving a couple of ResponsePending respondes a TimeoutException is fired. Actually the timeout should be reset.

I have created a fix, but no test case yes (I do have one, but it seems to be too complicated).

@pylessard
Copy link
Owner

Hello Alexander,
Thank you for your interest. Actually, this is the intended behaviour as you do not want your software to hangs indefinetely if your ECU keep sending "pending response". A way to exit the wait state is required.

Actually, following #19, I planned into adding a second timeout value. One for a single request and a second global timeout that won't be reset by the 0x78 NRC code.

I don not have a lot of time this week. This will need to wait a week or two.

@XelaRellum
Copy link
Author

OK, I see. Understand the reasoning behind this. For now I will just increase the overall timeout to the maximum expected pending time and I guess then I am fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants