Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper multiprocessing shutdown #3779

Closed
GergelyKalmar opened this issue Aug 18, 2020 · 0 comments · Fixed by #3869
Closed

Implement proper multiprocessing shutdown #3779

GergelyKalmar opened this issue Aug 18, 2020 · 0 comments · Fixed by #3869
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors

Comments

@GergelyKalmar
Copy link
Contributor

Steps to reproduce

  1. Use multiprocessing by setting jobs = 2.
  2. Run pytest with the pytest-pylint and pytest-cov plugins installed.
  3. There are a bunch of warnings reported by pytest-cov which are supposedly caused by pylint's multiprocessing pools not being shut down properly (see pytest-cov warnings when used with parallel pytest-pylint runs pytest-dev/pytest-cov#424)

See also https://pytest-cov.readthedocs.io/en/latest/subprocess-support.html#if-you-use-multiprocessing-pool and compare that with what is seen in the check_parallel function: https://github.com/PyCQA/pylint/blob/707fc4603b9d505bda68cf6adf9805882b99d73c/pylint/lint/check_parallel.py#L82-L83

Current behavior

There are various warnings related to temporary files produced by pytest-cov.

Expected behavior

There are no warnings and issues related to temporary files.

pylint --version output

pylint 2.5.3
astroid 2.4.2
Python 3.8.2 (default, Jul 16 2020, 14:00:26) 
[GCC 9.3.0]
@AWhetter AWhetter added Good first issue Friendly and approachable by new contributors Enhancement ✨ Improvement to a component labels Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants