unused-imports uses hardcoded list for typing.TYPE_CHECKING

[dcbaker]

In meson we import the typing module as T, as a sort of compromise between using the full typing name, and polluting the local namespace.

Steps to reproduce

import typing as T
if T.TYPE_CHECKING:
    import Foo

Looking at the code it uses a hardcoded set {'typing.TYPE_CHECKING', 'TYPE_CHECKING'}, using any other value will be ignored and spurious errors will ensue.

For my use, being able to add T.TYPE_CHECKING to the pylintrc would be sufficient, but maybe this can resolved in a more generic way?

[graingert]

pylint should definitely track what typing is imported as, and really must not consider import keyboarding as typing; typing.TYPE_CHECKING a match either.

but you'll probably not need this as most of the common stuff in typing is now moved to builtins and collections.abc

Then all the uncomon stuff typing.Protocol, typing.TypeVar, typing.cast justify using the full import typing name

[graingert]

there's also

MYPY = False
if MYPY:
    import bar

to consider

[dcbaker]

We need to support all versions of python the python foundation does. We're just getting ready to drop 3.5 support after our next release. So using the not in typing names won't happen for a lot of years for us.

[graingert]

@dcbaker you don't need python 3.9+ to use pep585 generics in builtins, mypy will support them (in forward annotations) on all Python versions

[PCManticore]

Thanks for the report; I agree that we need to improve the situation here.