Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit a message for unhashable set items #7055

Closed
mbyrnepr2 opened this issue Jun 25, 2022 · 0 comments · Fixed by #7036
Closed

Emit a message for unhashable set items #7055

mbyrnepr2 opened this issue Jun 25, 2022 · 0 comments · Fixed by #7036
Assignees
@jacobtylerwalls
Labels
Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code
Milestone
2.15.0

Comments

@mbyrnepr2
Copy link
Member

Current problem

The following example leads to a TypeError since the first item is not hashable:

{[1, 2, 3], "tomato"}

Desired solution

Emit a message indicating the TypeError.

Additional context

Similar to: #7034 (unhashable dict keys).
@mbyrnepr2 mbyrnepr2 added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Jun 25, 2022
@jacobtylerwalls jacobtylerwalls added Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code Needs PR This issue is accepted, sufficiently specified and now needs an implementation and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Jun 25, 2022
@jacobtylerwalls jacobtylerwalls self-assigned this Jun 25, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.15.0 milestone Jun 25, 2022
@jacobtylerwalls jacobtylerwalls mentioned this issue Jun 25, 2022
Merged
@Pierre-Sassoulas Pierre-Sassoulas removed the Needs PR This issue is accepted, sufficiently specified and now needs an implementation label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code
Projects
None yet
Milestone
2.15.0
Development

Successfully merging a pull request may close this issue.

Emit unhashable-member when creating sets or dicts jacobtylerwalls/pylint
3 participants
@Pierre-Sassoulas @mbyrnepr2 @jacobtylerwalls