Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the governance model and the path to maintainership #8329

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

This is done due to clarify our standing on moderation issues related to the recent PyCQA discussion, and also as part of the work done for the OpenSSF best practices (that Tidelift is paying me to do to make the software supply chain more secure). To be clear having an autocrat behaving like an asshole as the owner of a project is a liability for everyone in the software supply chain. Making sure that this does not happen for pylint is valuable. The way to become a maintainer is also a frequently asked question.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #8329 (d357be6) into main (c4f059b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8329   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         177      177           
  Lines       18704    18704           
=======================================
  Hits        17856    17856           
  Misses        848      848           

Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestion.

In general, I tend to prefer some ambiguity when it comes to these things. Nobody should think they are entitled to become a maintainer / or even an admin.

However, I do understand the intention to have something written and agreed upon.

doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member Author

I feel like some defining characteristics of pylint that are not up for discussion should be explained here as well, I'm thinking of:

  • We favor false negatives over false positives
  • New messages should be opt-in if it's opinionated (even a little)
  • We favor correctness over performance, because pylint is not used for its performance, BUT performance is important and need to be taken into account from the get go
  • If there's a hard decision to take we try to add an option so that pylint is one size fit all (after configuration)
  • ... ?

I'm sure there are other implicit rules that we agree on but I don't think of anything else right now ...

Comment on lines 25 to 42
your review, you're going to be able to merge those yourself soon).
- Have an admin suggest that you become maintainer, without you asking
- Get unanimous approval or neutral agreement from current maintainers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's self explanatory so not sure it should be added:

Have been a triager for x amount of time / multiple months

If it's added, something similar could be added to the admin section as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ollie-iterators
Copy link
Contributor

This is great. Thanks for doing this @Pierre-Sassoulas

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
doc/development_guide/contributor_guide/governance.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I don't care too much about it as I think most of this is fairly self explanatory but might be good to document it.

I said this before but I do feel the OpenSSF is focusing an awful lot on minor details that take away from actually improving projects that fall under it, but oh wel...

Pierre-Sassoulas and others added 2 commits February 23, 2023 23:57
Apply suggestions from code review

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@Pierre-Sassoulas
Copy link
Member Author

I'm not doing this only for OpenSSF. There are more fundamental requirements of OpenSSF, but we're already very advanced on what we do regarding fundamental stuff (license/tests/bug reporting/ documentation/CI/rights), so the actual way to make pylint better are becoming more and more "niche". Being explicit about the code of conduct being enforced for everyone is important (to me) due to PyCQA meta issue 54.

I'm open on working for specific aspects that you find more impactful next, see https://bestpractices.coreinfrastructure.org/en/projects/6328

@Pierre-Sassoulas Pierre-Sassoulas merged commit 8bf1120 into pylint-dev:main Feb 24, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrade-to-the-contribution-guide branch February 24, 2023 12:41
@Pierre-Sassoulas
Copy link
Member Author

Thank you for the review @mbyrnepr2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants