Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all old code related to optparse config parsing. #8405

Merged
merged 2 commits into from Mar 8, 2023

Conversation

DanielNoord
Copy link
Collaborator

Type of Changes

Type
βœ“ πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Bye bye

@DanielNoord DanielNoord added Breaking changes for 3.0 🦀 Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 8, 2023
@DanielNoord DanielNoord added this to the 3.0.0 milestone Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #8405 (2679239) into main (1ed1ab0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8405      +/-   ##
==========================================
+ Coverage   95.59%   95.63%   +0.03%     
==========================================
  Files         177      176       -1     
  Lines       18688    18612      -76     
==========================================
- Hits        17865    17799      -66     
+ Misses        823      813      -10     
Impacted Files Coverage Ξ”
pylint/config/find_default_config_files.py 89.47% <ΓΈ> (-0.89%) ⬇️
pylint/lint/pylinter.py 96.00% <ΓΈ> (+0.68%) ⬆️
pylint/checkers/base_checker.py 95.20% <100.00%> (-0.08%) ⬇️
pylint/config/__init__.py 100.00% <100.00%> (ΓΈ)
pylint/config/_pylint_config/generate_command.py 100.00% <100.00%> (ΓΈ)
pylint/config/arguments_manager.py 100.00% <100.00%> (+2.10%) ⬆️
pylint/config/arguments_provider.py 100.00% <100.00%> (+5.12%) ⬆️
pylint/config/callback_actions.py 100.00% <100.00%> (ΓΈ)
pylint/config/utils.py 100.00% <100.00%> (ΓΈ)
pylint/lint/utils.py 96.55% <100.00%> (ΓΈ)
... and 3 more

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a cleanup ! πŸ”₯

@DanielNoord DanielNoord merged commit 3318aa0 into pylint-dev:main Mar 8, 2023
40 of 43 checks passed
@DanielNoord DanielNoord deleted the optparse-removal branch March 8, 2023 19:53
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 2679239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes for 3.0 🦀 Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants