Fix a false negative for duplicate-argument-name
#9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ositional-only``, ``*args`` and ``**kwargs`` arguments in the check. Closes pylint-dev#9669
mbyrnepr2
added
the
False Negative π¦
mbyrnepr2
commented
May 22, 2024
| @@ -145,7 +145,7 @@ class BasicErrorChecker(_BasicChecker): | |||
| "pre-decrement operator -- and ++, which doesn't exist in Python.", | |||
| ), | |||
| "E0108": ( | |||
| "Duplicate argument name %s in function definition", | |||
| "Duplicate argument name %r in function definition", | |||
There was a problem hiding this comment.
This is an incidental change to add quotes to the name of the missing argument in the message output.
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9670 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 174 174
Lines 18904 18901 -3
==========================================
- Hits 18118 18115 -3
Misses 786 786
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
for more information, see https://pre-commit.ci
Pierre-Sassoulas
approved these changes
May 22, 2024
|
Let's wait for another review, 3.3.0 is not out yet :) |
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit aab51bb |
DanielNoord
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false negative for
duplicate-argument-nameby includingpositional-only,*argsand**kwargsarguments in the check.Closes #9669