Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests.tensor.test_basic #101

Merged
merged 4 commits into from Oct 23, 2020

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Oct 12, 2020

This PR moves the following tests out from the gigantic tests.tensor.test_basic module and into their own modules:

  • the utility functions (tests.tensor.utils),
  • the SciPy-specific tests (tests.tensor.test_basic_scipy),
  • the theano.tensor.inplace tests (tests.tensor.test_inplace),
  • the numpy function wrapper Ops defined using _scal_elemwise and tested using makeBroadcastTester (tests.tensor.test_numpy)

@brandonwillard brandonwillard added refactor This issue involves refactoring testing labels Oct 12, 2020
@brandonwillard brandonwillard added this to the Clean up Theano milestone Oct 12, 2020
@brandonwillard brandonwillard self-assigned this Oct 12, 2020
- Remove unused tests and unnecessary helper functions
- Rename camel-case tests
- Use pytest.raises
@brandonwillard brandonwillard merged commit 7f1537c into aesara-devs:master Oct 23, 2020
@brandonwillard brandonwillard deleted the refactor-tests branch October 23, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor This issue involves refactoring testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant