Fix imports style #122
Merged
Fix imports style #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
fix-imports-style
branch
6 times, most recently
from
46ffab0
to
e9fd2f6
Compare
Most of the bugbears involved `assert False` and bad function keyword defaults. In tests, the former often signaled needed `pytest.raises` rewrites.
Two new modules were made in order to remove the circular references: `theano.gpuarray.dnn_opt` (i.e. optimizations specific to `theano.gpuarray.dnn`) and `theano.gpuarray.optdb` (i.e. optimization databases for gpuarray `Op`s).
brandonwillard
force-pushed
the
fix-imports-style
branch
from
023deb6
to
008579b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
isortto our style checks.As a necessary part of this addition, a few more import cycles needed to be broken (e.g. a bad one involving the optimizations in
theano.gpuarray). Also, some Python 2.x fixes were made usingpyupgrade.