Split apart broadcast_shape so that it can work with many arguments #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use Python varargs, we're limited in the number of arrays/shapes that can be processed/given. Now, there's a `broadcast_shape_iter` that takes a collection of arrays/shapes and doesn't face this restriction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a limitation brought about by the use of Python's varargs:
broadcast_shapeis limited in the number of arrays/shapes that can be processed/given. In this PR, abroadcast_shape_iteris introduced, and it takes a collection of arrays/shapes and—as a result—doesn't face this restriction.